💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

would love to have this backported to older versions :)

First PR to electron, exciting! Here's some reasoning for this (which I'm not sure if it belongs in this comment or up top):

Currency codes are often used in the front and backend for various reasons. Having that information readily available let's us categorize the expected income better and create estimations of revenue much more easily since we can take the currency that's there and get an idea of the value of the transaction. It is also often used by 3rd party billing services for the magic blackbox that is their products. On the front end, while we currently are able to get properly formatted string for the price, we can't really use the info that is there to 'continue the conversation' so to speak, here's an example:

const products = inAppPurchase.getProducts(['mysku']);
if (products.length > 0) {
    const productPrice = products[0].price;
    const currency = products[0].currencyCode;
    const locale = 'de-DE';
    const currencyLocalizer = new Intl.NumberFormat(locale, { style: 'currency', currency })
    const tenLocalizedBucks = currencyLocalizer.format(10)
    alert(`You can get a subscription for {productPrice}! Isn't the savings incredible? Tip your barista {tenLocalizedBucks} the next time you get a latte!`);
}

If the currency code came back as 'EUR' we'd see "10,00 €", but if it came back as something else from Apple such as "XPF" we'd see "10 CFPF" instead.

Apple is the source of truth for the currency a user is shown, we can't rely on anything else if we want the way we show pricing to be consistent across not only the app but also the native checkout dialogs.

@svirs looks like lint is failing:

$ node ./script/lint.js && npm run lint:clang-format && npm run lint:docs
shell/browser/mac/in_app_purchase_product.mm:153:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Total errors found: 1

this lgtm otherwise tho!

@codebytere fixed!

Would it all right to label this with target/9-x-y?

@svirs That would require a minor bump and therefore needs to go through the release WG. I can tag it for review though 😄

Congrats on merging your first pull request! 🎉🎉🎉

Release Notes Persisted

Added the currencyCode field that Apple's StoreKit in-app-purchasing library provides but has not been added to the Product object that inAppPurchase.getProducts returns.

I have automatically backported this PR to "10-x-y", please check out #25084

(tagging the actual backports with backport/requested instead)

I have automatically backported this PR to "9-x-y", please check out #25085

Woo! Looking forward to the nightly thanks y'all!